🎨 Optimize code

This commit is contained in:
2025-06-22 15:08:38 +08:00
parent 35c89e086e
commit eb9b037f8e
22 changed files with 937 additions and 1906 deletions

View File

@@ -11,8 +11,10 @@ package services
import "C"
import (
"context"
"fmt"
"sync"
"sync/atomic"
"time"
"voidraft/internal/models"
@@ -20,17 +22,19 @@ import (
"github.com/wailsapp/wails/v3/pkg/services/log"
)
// HotkeyService 全局热键服务
// HotkeyService Windows全局热键服务
type HotkeyService struct {
logger *log.LoggerService
configService *ConfigService
app *application.App
mu sync.RWMutex
isRegistered bool
currentHotkey *models.HotkeyCombo
stopChan chan struct{}
wg sync.WaitGroup
running bool
isRegistered atomic.Bool
ctx context.Context
cancel context.CancelFunc
wg sync.WaitGroup
}
// HotkeyError 热键错误
@@ -39,27 +43,26 @@ type HotkeyError struct {
Err error
}
// Error 实现error接口
func (e *HotkeyError) Error() string {
return fmt.Sprintf("hotkey error during %s: %v", e.Operation, e.Err)
return fmt.Sprintf("hotkey %s: %v", e.Operation, e.Err)
}
// Unwrap 获取原始错误
func (e *HotkeyError) Unwrap() error {
return e.Err
}
// NewHotkeyService 创建新的热键服务实例
// NewHotkeyService 创建热键服务实例
func NewHotkeyService(configService *ConfigService, logger *log.LoggerService) *HotkeyService {
if logger == nil {
logger = log.New()
}
ctx, cancel := context.WithCancel(context.Background())
return &HotkeyService{
logger: logger,
configService: configService,
isRegistered: false,
running: false,
ctx: ctx,
cancel: cancel,
}
}
@@ -67,72 +70,57 @@ func NewHotkeyService(configService *ConfigService, logger *log.LoggerService) *
func (hs *HotkeyService) Initialize(app *application.App) error {
hs.app = app
// 加载并应用当前配置
config, err := hs.configService.GetConfig()
if err != nil {
return &HotkeyError{Operation: "load_config", Err: err}
return &HotkeyError{"load_config", err}
}
if config.General.EnableGlobalHotkey {
err = hs.RegisterHotkey(&config.General.GlobalHotkey)
if err != nil {
hs.logger.Error("Hotkey: Failed to register hotkey on startup", "error", err)
if err := hs.RegisterHotkey(&config.General.GlobalHotkey); err != nil {
hs.logger.Error("failed to register startup hotkey", "error", err)
}
}
hs.logger.Info("Hotkey: Service initialized")
return nil
}
// RegisterHotkey 注册全局热键
func (hs *HotkeyService) RegisterHotkey(hotkey *models.HotkeyCombo) error {
if !hs.isValidHotkey(hotkey) {
return &HotkeyError{"validate", fmt.Errorf("invalid hotkey combination")}
}
hs.mu.Lock()
defer hs.mu.Unlock()
// 取消注册现有热键
if hs.isRegistered {
hs.logger.Info("Hotkey: Unregistering existing hotkey before registering new one")
err := hs.unregisterHotkeyInternal()
if err != nil {
return err
}
// 取消现有热键
if hs.isRegistered.Load() {
hs.unregisterInternal()
}
// 验证热键组合
if !hs.isValidHotkey(hotkey) {
return &HotkeyError{Operation: "validate_hotkey", Err: fmt.Errorf("invalid hotkey combination")}
}
hs.logger.Info("Hotkey: Registering global hotkey using Windows API",
"ctrl", hotkey.Ctrl,
"shift", hotkey.Shift,
"alt", hotkey.Alt,
"win", hotkey.Win,
"key", hotkey.Key)
// 创建ready channel等待goroutine启动完成
readyChan := make(chan struct{})
// 确保 stopChan 是新的
hs.stopChan = make(chan struct{})
// 启动监听器
ctx, cancel := context.WithCancel(hs.ctx)
hs.wg.Add(1)
go hs.hotkeyListener(hotkey, readyChan)
// 等待监听器启动完成,设置超时避免无限等待
ready := make(chan error, 1)
go hs.hotkeyListener(ctx, hotkey, ready)
// 等待启动完成
select {
case <-readyChan:
// 监听器启动完成
case <-time.After(1 * time.Second):
// 超时处理
hs.logger.Warning("Hotkey: Timeout waiting for listener to start")
return &HotkeyError{Operation: "start_listener", Err: fmt.Errorf("timeout waiting for hotkey listener to start")}
case err := <-ready:
if err != nil {
cancel()
return &HotkeyError{"register", err}
}
case <-time.After(time.Second):
cancel()
return &HotkeyError{"register", fmt.Errorf("timeout")}
}
hs.currentHotkey = hotkey
hs.isRegistered = true
hs.running = true
hs.isRegistered.Store(true)
hs.cancel = cancel
hs.logger.Info("Hotkey: Successfully registered global hotkey")
return nil
}
@@ -140,204 +128,85 @@ func (hs *HotkeyService) RegisterHotkey(hotkey *models.HotkeyCombo) error {
func (hs *HotkeyService) UnregisterHotkey() error {
hs.mu.Lock()
defer hs.mu.Unlock()
return hs.unregisterHotkeyInternal()
return hs.unregisterInternal()
}
// unregisterHotkeyInternal 内部取消注册方法(无锁)
func (hs *HotkeyService) unregisterHotkeyInternal() error {
if !hs.isRegistered {
hs.logger.Debug("Hotkey: No hotkey registered, skipping unregister")
// unregisterInternal 内部取消注册(无锁)
func (hs *HotkeyService) unregisterInternal() error {
if !hs.isRegistered.Load() {
return nil
}
hs.logger.Info("Hotkey: Unregistering global hotkey")
// 停止监听
if hs.stopChan != nil {
close(hs.stopChan)
hs.logger.Debug("Hotkey: Waiting for listener goroutine to stop")
if hs.cancel != nil {
hs.cancel()
hs.wg.Wait()
hs.logger.Debug("Hotkey: Listener goroutine stopped")
}
// 重置状态
hs.currentHotkey = nil
hs.isRegistered = false
hs.running = false
hs.stopChan = nil
hs.logger.Info("Hotkey: Successfully unregistered global hotkey")
hs.isRegistered.Store(false)
return nil
}
// UpdateHotkey 更新热键配置
func (hs *HotkeyService) UpdateHotkey(enable bool, hotkey *models.HotkeyCombo) error {
hs.logger.Info("Hotkey: === UpdateHotkey called ===",
"enable", enable,
"ctrl", hotkey.Ctrl,
"shift", hotkey.Shift,
"alt", hotkey.Alt,
"win", hotkey.Win,
"key", hotkey.Key)
// 先获取当前状态
hs.mu.RLock()
currentRegistered := hs.isRegistered
var currentHotkey *models.HotkeyCombo
if hs.currentHotkey != nil {
currentHotkey = &models.HotkeyCombo{
Ctrl: hs.currentHotkey.Ctrl,
Shift: hs.currentHotkey.Shift,
Alt: hs.currentHotkey.Alt,
Win: hs.currentHotkey.Win,
Key: hs.currentHotkey.Key,
}
}
hs.mu.RUnlock()
hs.logger.Info("Hotkey: Current state",
"currentRegistered", currentRegistered,
"currentHotkey", currentHotkey)
// 检查是否需要更新
needsUpdate := false
if enable != currentRegistered {
needsUpdate = true
hs.logger.Info("Hotkey: Enable state changed", "old", currentRegistered, "new", enable)
} else if enable && currentHotkey != nil {
// 如果启用状态,检查热键组合是否变化
if hotkey.Ctrl != currentHotkey.Ctrl ||
hotkey.Shift != currentHotkey.Shift ||
hotkey.Alt != currentHotkey.Alt ||
hotkey.Win != currentHotkey.Win ||
hotkey.Key != currentHotkey.Key {
needsUpdate = true
hs.logger.Info("Hotkey: Hotkey combination changed",
"old", fmt.Sprintf("Ctrl:%v Shift:%v Alt:%v Win:%v Key:%s",
currentHotkey.Ctrl, currentHotkey.Shift, currentHotkey.Alt, currentHotkey.Win, currentHotkey.Key),
"new", fmt.Sprintf("Ctrl:%v Shift:%v Alt:%v Win:%v Key:%s",
hotkey.Ctrl, hotkey.Shift, hotkey.Alt, hotkey.Win, hotkey.Key))
}
}
if !needsUpdate {
hs.logger.Info("Hotkey: No changes detected, skipping update")
return nil
}
hs.logger.Info("Hotkey: Proceeding with hotkey update", "needsUpdate", needsUpdate)
if enable {
// 启用热键直接注册新热键RegisterHotkey 会处理取消旧热键)
err := hs.RegisterHotkey(hotkey)
if err != nil {
hs.logger.Error("Hotkey: Failed to register new hotkey", "error", err)
return err
}
hs.logger.Info("Hotkey: Successfully updated and registered new hotkey")
return nil
} else {
// 禁用热键:取消注册
err := hs.UnregisterHotkey()
if err != nil {
hs.logger.Error("Hotkey: Failed to unregister hotkey", "error", err)
return err
}
hs.logger.Info("Hotkey: Successfully disabled hotkey")
return nil
return hs.RegisterHotkey(hotkey)
}
return hs.UnregisterHotkey()
}
// ToggleWindow 切换窗口显示/隐藏 - 通过事件通知前端处理
func (hs *HotkeyService) ToggleWindow() {
if hs.app == nil {
hs.logger.Warning("Hotkey: App is nil, cannot toggle")
return
}
// 发送事件到前端,让前端处理窗口切换
hs.app.EmitEvent("hotkey:toggle-window", nil)
hs.logger.Debug("Hotkey: Emitted toggle window event")
}
// hotkeyListener 热键监听器goroutine
func (hs *HotkeyService) hotkeyListener(hotkey *models.HotkeyCombo, readyChan chan struct{}) {
// hotkeyListener 热键监听器
func (hs *HotkeyService) hotkeyListener(ctx context.Context, hotkey *models.HotkeyCombo, ready chan<- error) {
defer hs.wg.Done()
hs.logger.Debug("Hotkey: Starting Windows API hotkey listener")
// 将热键转换为虚拟键码
mainKeyVK := hs.keyToVirtualKeyCode(hotkey.Key)
if mainKeyVK == 0 {
hs.logger.Error("Hotkey: Invalid key", "key", hotkey.Key)
close(readyChan)
ready <- fmt.Errorf("invalid key: %s", hotkey.Key)
return
}
// 检查间隔100ms减少CPU使用率
ticker := time.NewTicker(100 * time.Millisecond)
defer ticker.Stop()
// 添加状态跟踪
var wasPressed bool = false
// 标记是否已经发送ready信号确保只发送一次
readySent := false
var wasPressed bool
ready <- nil // 标记准备就绪
for {
select {
case <-hs.stopChan:
hs.logger.Debug("Hotkey: Stopping Windows API hotkey listener")
if !readySent {
close(readyChan)
}
case <-ctx.Done():
return
case <-ticker.C:
// 第一次循环时发送ready信号表示监听器已经准备就绪
if !readySent {
close(readyChan)
readySent = true
hs.logger.Debug("Hotkey: Listener ready signal sent")
}
ctrl := cBool(hotkey.Ctrl)
shift := cBool(hotkey.Shift)
alt := cBool(hotkey.Alt)
win := cBool(hotkey.Win)
// 调用 C 函数检查热键组合
ctrl := 0
if hotkey.Ctrl {
ctrl = 1
}
isPressed := C.isHotkeyPressed(ctrl, shift, alt, win, C.int(mainKeyVK)) == 1
shift := 0
if hotkey.Shift {
shift = 1
}
alt := 0
if hotkey.Alt {
alt = 1
}
win := 0
if hotkey.Win {
win = 1
}
// 检查热键是否被按下
isPressed := int(C.isHotkeyPressed(C.int(ctrl), C.int(shift), C.int(alt), C.int(win), C.int(mainKeyVK))) == 1
// 只在按键从未按下变为按下时触发(边缘触发)
if isPressed && !wasPressed {
hs.logger.Debug("Hotkey: Global hotkey triggered via Windows API")
hs.ToggleWindow()
hs.toggleWindow()
}
// 更新状态
wasPressed = isPressed
}
}
}
// keyToVirtualKeyCode 将键名转换为 Windows 虚拟键码
// cBool 转换Go bool为C int
func cBool(b bool) C.int {
if b {
return 1
}
return 0
}
// toggleWindow 切换窗口
func (hs *HotkeyService) toggleWindow() {
if hs.app != nil {
hs.app.EmitEvent("hotkey:toggle-window", nil)
}
}
// keyToVirtualKeyCode 键名转虚拟键码
func (hs *HotkeyService) keyToVirtualKeyCode(key string) int {
keyMap := map[string]int{
// 字母键
@@ -345,43 +214,29 @@ func (hs *HotkeyService) keyToVirtualKeyCode(key string) int {
"I": 0x49, "J": 0x4A, "K": 0x4B, "L": 0x4C, "M": 0x4D, "N": 0x4E, "O": 0x4F, "P": 0x50,
"Q": 0x51, "R": 0x52, "S": 0x53, "T": 0x54, "U": 0x55, "V": 0x56, "W": 0x57, "X": 0x58,
"Y": 0x59, "Z": 0x5A,
// 数字键
"0": 0x30, "1": 0x31, "2": 0x32, "3": 0x33, "4": 0x34,
"5": 0x35, "6": 0x36, "7": 0x37, "8": 0x38, "9": 0x39,
// 功能键
"F1": 0x70, "F2": 0x71, "F3": 0x72, "F4": 0x73, "F5": 0x74, "F6": 0x75,
"F7": 0x76, "F8": 0x77, "F9": 0x78, "F10": 0x79, "F11": 0x7A, "F12": 0x7B,
}
if vk, exists := keyMap[key]; exists {
return vk
}
return 0
return keyMap[key]
}
// isValidHotkey 验证热键组合是否有效
// isValidHotkey 验证热键组合
func (hs *HotkeyService) isValidHotkey(hotkey *models.HotkeyCombo) bool {
if hotkey == nil {
if hotkey == nil || hotkey.Key == "" {
return false
}
// 必须有主键
if hotkey.Key == "" {
return false
}
// 必须至少有一个修饰键
// 至少需要一个修饰键
if !hotkey.Ctrl && !hotkey.Shift && !hotkey.Alt && !hotkey.Win {
return false
}
// 验证主键是否在有效范围内
return hs.keyToVirtualKeyCode(hotkey.Key) != 0
}
// GetCurrentHotkey 获取当前注册的热键
// GetCurrentHotkey 获取当前热键
func (hs *HotkeyService) GetCurrentHotkey() *models.HotkeyCombo {
hs.mu.RLock()
defer hs.mu.RUnlock()
@@ -390,7 +245,6 @@ func (hs *HotkeyService) GetCurrentHotkey() *models.HotkeyCombo {
return nil
}
// 返回副本避免并发问题
return &models.HotkeyCombo{
Ctrl: hs.currentHotkey.Ctrl,
Shift: hs.currentHotkey.Shift,
@@ -400,25 +254,14 @@ func (hs *HotkeyService) GetCurrentHotkey() *models.HotkeyCombo {
}
}
// IsRegistered 检查是否已注册热键
// IsRegistered 检查是否已注册
func (hs *HotkeyService) IsRegistered() bool {
hs.mu.RLock()
defer hs.mu.RUnlock()
return hs.isRegistered
return hs.isRegistered.Load()
}
// ServiceShutdown 关闭热键服务
// ServiceShutdown 关闭服务
func (hs *HotkeyService) ServiceShutdown() error {
hs.mu.Lock()
defer hs.mu.Unlock()
if hs.isRegistered {
err := hs.unregisterHotkeyInternal()
if err != nil {
hs.logger.Error("Hotkey: Failed to unregister hotkey on shutdown", "error", err)
}
}
hs.logger.Info("Hotkey: Service shutdown completed")
hs.cancel()
hs.wg.Wait()
return nil
}